[FLINK-40554][runtime] Skipping job recovery for jobs with broken execution plan instead of failing cluster recovery hidden behind newly introduced config parameter cluster.job-error-isolation.enabled - #29107
Open
XComp wants to merge 1 commit into
Conversation
…cution plan instead of failing cluster recovery hidden behind newly introduced config parameter cluster.job-error-isolation.enabled The old implementation treated ExecutionPlan recovery errors as cluster-wide fatal causing the JobManager to fail over. This would cause other jobs on the same JobManager to failover as well. Enabling the new feature through the newly added configuration parameter makes the job recovery being skipped rather than failing the JobManager since the job wouldn't recover anyway. Cleanup needs to be handled manually by the operator. The error is revealed via error logs.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old implementation treated ExecutionPlan recovery errors as cluster-wide fatal causing the JobManager to fail over. This would cause other jobs on the same JobManager to failover as well. Enabling the new feature through the newly added configuration parameter makes the job recovery being skipped rather than failing the JobManager since the job wouldn't recover anyway. Cleanup needs to be handled manually by the operator. The error is revealed via error logs.
What is the purpose of the change
Creates new configuration parameter (with the feature being disabled by default). Enabling the feature would skip job recovery for that job and emits an error log message instead for manual cleanup. This prevents JobManager failover.
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation
Was generative AI tooling used to co-author this PR?
Generated-by: Claude